Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip extractor needs .net framework installed, but main application may use a self contained distribution #641

Closed
bob-dawson opened this issue Oct 12, 2023 · 4 comments

Comments

@bob-dawson
Copy link

Zip extractor needs .net framework installed, but main application may use a .net self-contained distribution. So, the main application can run on a machine without .net framework installed. Should provide an Api to specify application's own zip extractor instead of the embedded zip extractor. Or the zip extractor replaced with some program which has no other dependency.

@ravibpatel
Copy link
Owner

Currently, You can compile a self-contained ZipExtractor to resolve this issue. Doing this increases the size of the DLL significantly, that's why it is not compiled as self-contained EXE.

@prj
Copy link

prj commented Oct 25, 2023

Compiling ZipExtractor for anything except .net framework 4.5 is completely broken at the moment.
The resulting exe is not usable because it depends on .dll and .json files.

AutoUpdater.NET only adds the exe into the resources, so the end result is an assembly that is impossible to use.

Hence the given solution ("you can compile it yourself") is not valid.
Furthermore it means that it is impossible to compile this project to a working state in VS2022.

@ravibpatel
Copy link
Owner

@prj You have to publish the ZipExtractor instead of building it to produce a single executable without .dll or any JSON files. I updated the Readme.md to mention this. You can publish it as shown here.

@ravibpatel
Copy link
Owner

Now I am embedding ZipExtractor compiled using .NET Framework 4.5. Can you try DLL from here? It should work fine on Windows 8 or above without installing anything, even with self-contained apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants