Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File exist exception(System.IO.IOException) after download. #589

Closed
brallow opened this issue Dec 6, 2022 · 1 comment
Closed

File exist exception(System.IO.IOException) after download. #589

brallow opened this issue Dec 6, 2022 · 1 comment

Comments

@brallow
Copy link

brallow commented Dec 6, 2022

If AutoUpdater.XML's URL set without a filename suffix, Like 'http:https://10.10.10.10/' and it redirect to a valid URL which contains the ZIP file. The update dialog will shown and the exception will be shown after downloading.

The problem may at DownloadUpdateDialog.cs Line 110~124(ver 1.7.6)

Line 110: variable 'fileName' assigned with EMPTY string. Then, Line 124: File.Move(_tempFile,tempPath). parameter1 _tempFile is a full path filename. Parameter 2 tempPath link to the same path without any filename. It moves a file to its current path!
Uploading Xnip2022-12-06_13-06-52.png…

@ravibpatel
Copy link
Owner

If the URL has no filename suffix, then it should provide the valid content-disposition header with filename so AutoUpdater.NET can determine the file extension from the name. It is necessary cause it works with different file extensions and update behavior change according to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants