Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling internet connection errors #410

Closed
seltix5 opened this issue Sep 21, 2020 · 5 comments
Closed

handling internet connection errors #410

seltix5 opened this issue Sep 21, 2020 · 5 comments

Comments

@seltix5
Copy link

seltix5 commented Sep 21, 2020

hello,

after analising the code to try to handle the internet connections errors myself, I think it is not possible?
from what I understand, here :

var result = CheckUpdate(assembly);

if the CheckUpdate() throws a exception it will never call StartUpdate() and there is no other way to manually handle the error other than the ReportErrors variable to show the message.

Maybe the StartUpdate() should be in a separate try catch ? that way this code example could work :

@"There is a problem reaching update server. Please check your internet connection and try again later.",

or throw the exception if ReportErrors is false ?

thanks!

@Summer006
Copy link

I agree.
my app is check update at start (force update if available, no cancel, no next time), after that enter main app ui.
but if user network not working, whole app is stuck at update checking.
no failed message, no exception thrown, no event fired.
to fixed that , I had to check that url is reachable or not, before call update check.

I suggest that, add a 'FailedReason' enum type in event parameter, it can tell what error type of this failure.
like network issue / domain issue / host connection issue / http response error/ xml parse error / no error

@seltix5
Copy link
Author

seltix5 commented Nov 3, 2020

Closed with no reply? :/

@ravibpatel
Copy link
Owner

New commit added the ability check errors in check for update event. You can check it out.

@seltix5
Copy link
Author

seltix5 commented Nov 4, 2020

New commit added the ability check errors in check for update event. You can check it out.

in my project is use the NuGet version ( https://www.nuget.org/packages/Autoupdater.NET.Official/1.6.3?_src=template ), how does it work for updates? since apparently there is no new update there.
Thanks!

@ravibpatel
Copy link
Owner

I haven't released the NuGet package but you can try it from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants