-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handling internet connection errors #410
Comments
I agree. I suggest that, add a 'FailedReason' enum type in event parameter, it can tell what error type of this failure. |
Closed with no reply? :/ |
New commit added the ability check errors in check for update event. You can check it out. |
in my project is use the NuGet version ( https://www.nuget.org/packages/Autoupdater.NET.Official/1.6.3?_src=template ), how does it work for updates? since apparently there is no new update there. |
I haven't released the NuGet package but you can try it from here. |
hello,
after analising the code to try to handle the internet connections errors myself, I think it is not possible?
from what I understand, here :
AutoUpdater.NET/AutoUpdater.NET/AutoUpdater.cs
Line 288 in 974a876
if the CheckUpdate() throws a exception it will never call StartUpdate() and there is no other way to manually handle the error other than the ReportErrors variable to show the message.
Maybe the StartUpdate() should be in a separate try catch ? that way this code example could work :
AutoUpdater.NET/AutoUpdaterTest/FormMain.cs
Line 217 in f07d5da
or throw the exception if ReportErrors is false ?
thanks!
The text was updated successfully, but these errors were encountered: