From 8e878844719bc0aa750b6ab20cd39b00c5ada059 Mon Sep 17 00:00:00 2001 From: Ravi Patel Date: Thu, 15 Feb 2024 11:12:58 +0530 Subject: [PATCH] Using Utils.BuildArguments to create arguments string for MSI installer causes issues so reverted that change. This fixes #664. --- AutoUpdater.NET/DownloadUpdateDialog.cs | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/AutoUpdater.NET/DownloadUpdateDialog.cs b/AutoUpdater.NET/DownloadUpdateDialog.cs index 2507b2f..e63e58f 100644 --- a/AutoUpdater.NET/DownloadUpdateDialog.cs +++ b/AutoUpdater.NET/DownloadUpdateDialog.cs @@ -230,18 +230,11 @@ private void WebClientOnDownloadFileCompleted(object sender, AsyncCompletedEvent FileName = "msiexec" }; - var arguments = new Collection - { - "/i", - tempPath - }; - + processStartInfo.Arguments = $"/i \"{tempPath}\""; if (!string.IsNullOrEmpty(installerArgs)) { - arguments.Add(installerArgs); + processStartInfo.Arguments += $" {installerArgs}"; } - - processStartInfo.Arguments = Utils.BuildArguments(arguments); } if (AutoUpdater.RunUpdateAsAdmin)