Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every event should be of type TypedTargetEvent #17

Closed
cornerman opened this issue Dec 3, 2017 · 2 comments
Closed

Every event should be of type TypedTargetEvent #17

cornerman opened this issue Dec 3, 2017 · 2 comments

Comments

@cornerman
Copy link
Contributor

Currently, only a handful of the event properties are defined as a TypedTargetEvent, some are plain dom.Event. For convenience, it would be good if we could assume this for every event, i.e., every event is at least a TypedTargetEvent[dom.EventTarget].

@raquo
Copy link
Owner

raquo commented Dec 6, 2017

But dom.Event from scala-js-dom already has target typed as dom.EventTarget, no need for TypedTargetEvent[dom.EventTarget]. Or did you mean something else?

@cornerman
Copy link
Contributor Author

My use-case was that I wanted my EventPropBuilder to produce events of type TypedTargetEvent[_ <: dom.EventTarget]. But actually, I do not really need it anymore, so I can think we can close it again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants