Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate windowslinetermination from libcudf read_csv #15985

Open
lithomas1 opened this issue Jun 11, 2024 · 2 comments
Open

Deprecate windowslinetermination from libcudf read_csv #15985

lithomas1 opened this issue Jun 11, 2024 · 2 comments
Labels
cuIO cuIO issue good first issue Good for newcomers libcudf Affects libcudf (C++/CUDA) code.

Comments

@lithomas1
Copy link
Contributor

lithomas1 commented Jun 11, 2024

It doesn't do anything (there are only getters and setters for it defined in the csv header file, but it is not used in the csv reader cuda files).

See Github code search link
https://github.com/search?q=repo%3Arapidsai%2Fcudf%20windowslinetermination&type=code

@lithomas1 lithomas1 added libcudf Affects libcudf (C++/CUDA) code. cuIO cuIO issue labels Jun 11, 2024
@vyasr vyasr added the good first issue Good for newcomers label Jun 24, 2024
@yytsui
Copy link

yytsui commented Jul 3, 2024

First time here , I would like working on this to get familiar with the contribution working flow.

@vyasr
Copy link
Contributor

vyasr commented Jul 15, 2024

@yytsui apologies for the slow response! Please do, we'd love to have your help. Let us know if you have any issues getting started! I would recommend trying out the devcontainers as an easy starting point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuIO cuIO issue good first issue Good for newcomers libcudf Affects libcudf (C++/CUDA) code.
Projects
Status: In Progress
Development

No branches or pull requests

3 participants