-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport v2.7] Cannot create new cloud credentials for custom node drivers #8563
Comments
QA TEST PLAN Scenarios
|
Tested this against ENVIRONMENT DETAILS
TEST RESULT
VALIDATION STEPS Scenario 1
Scenario 2
|
This one is odd - I'm not super familiar w/ custom node drivers/cred but I think there might be a backend issue here. When I (try to?) create a cloud.ca credential, the HTTP response status is 201 (created) but the response body is null and when I visit Screen.Recording.2023-04-05.at.2.09.35.PM.movEdit: I've tried creating a cloud.ca RKE1 cluster in the old UI and I see different behavior entirely, where there is no attempt to create a cloud credential. I think we are likely handling some custom node drivers incorrectly in the dashboard; I'll continue to investigate |
cloud.ca and cloudscale both have custom UIs to handle credentials/node templates for the Ember UI, and the generic credential creator used for RKE2 provisioning doesn't work with them. Of the node drivers available by default, these are the only two that appear to have credential creation issues in the dashboard. There are some other node drivers that have custom UI defined for RKE1/ember, eg nutanix, but they don't have the same problem with cloud credential creation, though I don't have real credentials for any of these platforms to verify that others actually work with RKE2. How did this get the |
Looks like At this stage, we can push this out since it's not a blocker. However, we should dig into this for Q2. @mantis-toboggan-md what kind of credentials would you need? |
I don't know enough about this area to answer that with confidence @gaktive but of the custom in-tree node drivers, cloud.ca, cloudscale, nutanix, outscale, pinganyunecs, and phoenixnap have Maybe @nwmac knows more since he's looked into custom node drivers recently? |
Since we already have a Q2 ticket and it looks like we'll have to fix this then, we can close this ticket, unless @markusewalker has another workflow to use for QA tracking purposes However, @markusewalker do you have an environment that UI could use to access cloud.ca? |
@gaktive I do not have a workflow aside from this reported ticket that I am aware of. I can provide an environment first thing tomorrow morning offline to you both 😄 |
OK, based on the fact that this has been problem for a while, we'll close this but this will need a release note. |
This is a backport issue for #8523, automatically created via rancherbot by @mantis-toboggan-md
Original issue description:
Setup
7913e28
)Describe the bug
When enabling some custom node drivers, the Cloud Credential creation page doesn't not show the correct default fields, and has an uneditable
foo
key.To Reproduce
apiKey
) should show up the first time).Result
An unremovable
foo
key is presentExpected Result
Correct field
apiKey
shows in UIScreenshots
Additional context
I've noticed this on other cloud providers as well. As an aside, what populated these fields by default? Is it hard coded, or is it interpolated from available fields (from a list of
token
,apiKey
,password
, etc.), or is it coming from the backend somewhere and I've missed it?The text was updated successfully, but these errors were encountered: