New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add own translation key for "Delete Image" #3260

Closed

mantenie opened this issue Mar 5, 2020 · 1 comment · Fixed by #3382

Milestone

mantenie commented Mar 5, 2020

Currently the button to delete an image is solved by concatenating two translations:

https://github.com/sferik/rails_admin/blob/834c83da05f6194bf808f052e011d539ceaa3845/app/views/rails_admin/main/_form_file_upload.html.haml#L15

The problem is that in other languages, like German, the sequence of the words is grammatically wrong.

Author

mantenie commented Mar 5, 2020

A solution can be to replace the line with:

= I18n.t('admin.actions.delete.link', object_label: field.label)

mshibuya added this to the 3.0.0 milestone

codealchemy mentioned this issue

Update file upload translations to avoid concatenation #3382

Merged

mshibuya closed this as completed in #3382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment