Respect the use of the NO_COLOR environment variable #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Respect the declaration of the of the NO_COLOR environment variable as a sign that color output should be suppressed in he tool. This informal standard is described at https://no-color.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌈 An informal standard for disabling color codes across the many command line tools that output terminal color codes has been described at https://no-color.org
Many of the tools that I already use have begun to support the variable, and having it in Thor would eventually allow most of the Ruby ecosystem tools I support to gain the functionality as well.
This PR scratches this itch by implementing NO_COLOR as https://no-color.org defines it:
I'm unsure where the correct place to document this functionality might be. I grepped the source for permutations of "color" and "tty" to to cover the existing functionality. I'm happy to adjust this PR to include documentation if preferred. Just let me know if you want it and whether you have a preference for where it should be.