Use MiniMime for MIME type lookup by filename/extension #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7479fa1
to
197cc1d
Compare
|
Will fix CI on Ruby 2.2 separately. |
Cruikshanks
added a commit
to DEFRA/sroc-tcm-admin
that referenced
this pull request
Mar 25, 2021
First, scan [Dependency on mimemagic 0.3.x no longer valid](rails/rails#41750) for context! In summary, **rails** depends on **activestorage** which depends on **marcel** which depends on **mimemagic**. Yesterday, the author of **mimemagic** was informed it was in violation of the GPL license. So, they chose to - yank all versions up to and including 0.3.5 from rubygems - release a new version under the GPL - archive the project for all further changes/issues/pr's etc Via the dependency chain Rails relies on **mimemagic 0.3.5** so new installs of Rails are now broken. It also can't just pull in the new version due to the clash with the GPL license. Efforts are afoot to resolve the issue. - A [fork of mimemagic](https://github.com/jellybob/mimemagic) which relies on the GPL source data being already installed and read at run time - Updating **marcel** to use [MiniMime](rails/marcel#25) and [ruby-magic](rails/marcel#26) instead of **mimemagic** Till the community has settled on a solution though, we need a fix in the short term. Ours is based on - What the Dept. for Education team have done in [early-careers-framework](DFE-Digital/early-careers-framework#178) - What Sentry are doing [in their app](getsentry/sentry-ruby#1362) Instead of referencing `rails` in the `Gemfile` they are referencing just the parts needed and excluding `activestorage` and anything with a dependency on it. This change does exactly the same thing.
Cruikshanks
added a commit
to DEFRA/sroc-tcm-admin
that referenced
this pull request
Mar 26, 2021
First, scan [Dependency on mimemagic 0.3.x no longer valid](rails/rails#41750) for context! In summary, **Rails** depends on **activestorage** which depends on **marcel** which depends on **mimemagic**. Yesterday, the author of **mimemagic** was informed it was in violation of the [GPL license](https://choosealicense.com/licenses/gpl-3.0/). So, they chose to - yank all versions up to and including 0.3.5 from rubygems - release a new version under the GPL - archive the project for all further changes/issues/pr's etc Via the dependency chain **Rails** relies on **mimemagic 0.3.5** so new installs of **Rails** are now broken. It also can't just pull in the new version due to the clash with the GPL license. Efforts are afoot to resolve the issue. - A [fork of mimemagic](https://github.com/jellybob/mimemagic) which relies on the GPL source data being already installed and read at run time - Updating **marcel** to use [MiniMime](rails/marcel#25) and [ruby-magic](rails/marcel#26) instead of **mimemagic** Till the community has settled on a solution though, we need a fix in the short term. Ours is based on - What the Dept. for Education team have done in [early-careers-framework](DFE-Digital/early-careers-framework#178) - What Sentry are doing [in their app](getsentry/sentry-ruby#1362) Instead of referencing `rails` in the `Gemfile` they are referencing just the parts needed and excluding `activestorage` and anything with a dependency on it. This change does exactly the same thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.