Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of GeoStack and GeoSeries by sharing and caching dims #64

Closed
rafaqz opened this issue Sep 13, 2020 · 1 comment · Fixed by #168
Closed

Improve performance of GeoStack and GeoSeries by sharing and caching dims #64

rafaqz opened this issue Sep 13, 2020 · 1 comment · Fixed by #168

Comments

@rafaqz
Copy link
Owner

rafaqz commented Sep 13, 2020

When lazily loading GeoSeries the dims of the child files are being loaded/calculated for every file. This should be done once for the first file and copied for the rest. The assumption of the series is that all dims are the same.

This may break when it comes to attached metadata being different - that may need some subtlety to handle correctly.

GeoStack is also not sharing dims between layers in all cases. This is complicated by the fact that not all layers have the same dimensions - but they could choose from a list of shared dimensions, as is done internally in netcdf files.

@rafaqz
Copy link
Owner Author

rafaqz commented Oct 1, 2020

This could also involve inheriting from AbstractDimDataset - which would add whole stack function application and indexing.

However - it's a special case where N = Mixed(), as the layers can have different numbers of dims. It also means each layer needs to track the types of the dims it has so they can be retrieved from the shared dims tuple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant