Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix replace_missing when both missingval and newmissingval are missing #102

Merged
merged 1 commit into from
Nov 14, 2020

Conversation

rafaqz
Copy link
Owner

@rafaqz rafaqz commented Nov 14, 2020

closes #63

@codecov-io
Copy link

Codecov Report

Merging #102 (a6bbd87) into master (ff04dd6) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   78.46%   78.51%   +0.04%     
==========================================
  Files          18       18              
  Lines         980      982       +2     
==========================================
+ Hits          769      771       +2     
  Misses        211      211              
Impacted Files Coverage Δ
src/methods.jl 85.71% <100.00%> (+1.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff04dd6...a6bbd87. Read the comment docs.

@rafaqz rafaqz merged commit bbd31d8 into master Nov 14, 2020
@rafaqz rafaqz deleted the fix_reaplace_missing branch November 27, 2020 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace_missing should just do nothing if missingval is allready missing
2 participants