Make buffer for read! an AbstractArray
#411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failure on Julia nightly is due to a change in Julia Base removing length from Iterators.Stateful which is already reported in DiskArrays see meggart/DiskArrays.jl#142. |
yeesian
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This widens the dispatch of the
read!andrasterio!functions so that the buffer can be an AbstractArray instead of a normal Array. This will allow to also read into for example views or other array wrapper types like PermuteDimsArrays.This would close #410.
It will also close rafaqz/Rasters.jl#596
Should we also widen the buffer type for the write! functions?