Warp fixes #545
Merged
Warp fixes #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaqz
force-pushed
the
warp_fixes
branch
3 times, most recently
from
21ba904
to
2f91759
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
==========================================
+ Coverage 80.56% 80.83% +0.26%
==========================================
Files 57 57
Lines 4163 4174 +11
==========================================
+ Hits 3354 3374 +20
+ Misses 809 800 -9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bugs in
warpandresample, and their docs. Closes #537 and closes #538.This fix required some breaking changes, like, no longer automatically reversing the Y axis. I think it creates more trouble than its worth, like #502. So this also fixes #502 and fixes #384.
Unfortunately GDAL does a lot of its own reversing, shifting point locations and other weirdness in
gdalwarp. So we have to hack around it quite a bit.This PR also cleans up GDAL code a lot, standardising
write,createandRasterDatasetmethods to use most of the same code, which should make problems like this easier to reason about in future.