use StepRange rather than LinRange #429
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaqz
force-pushed
the
fix_lookup_accuracy
branch
from
a09e3ee
to
1c961db
Compare
rafaqz
force-pushed
the
fix_lookup_accuracy
branch
from
1c961db
to
e82da5c
Compare
|
Note: using step range is generally safer but has the small chance of complete failure even to load a raster if the length of the range is wrong due to floating point error. Its not clear what kind of error is preferable, but not even loading a raster seems worse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #427
@biskwikman your example works for me on this branch, you can check it out with
] add Rasters#fix_lookup_accuracyif you would like to give it a try.