Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes seem to be off #353

Closed
mauro3 opened this issue Dec 20, 2022 · 5 comments
Closed

Release notes seem to be off #353

mauro3 opened this issue Dec 20, 2022 · 5 comments

Comments

@mauro3
Copy link
Collaborator

mauro3 commented Dec 20, 2022

Looking at the release notes https://github.com/rafaqz/Rasters.jl/releases/tag/v0.5.0 I see that many of the carried over from previous releases, see https://github.com/rafaqz/Rasters.jl/releases?page=3; presumably something's off with the autogeneration.

Also, clicking on "Releases" on the main page gets one to https://github.com/rafaqz/Rasters.jl/releases, which first list the old GeoData.jl releases. Not sure something can be done about this though.

Last, just a wish: I just had a look at https://github.com/rafaqz/Rasters.jl/releases/tag/v0.5.0 and I don't know what is breaking. Would be great if it was documented, just a "(breaking)" behind the closed issue/merged PR would be perfect.

@rafaqz
Copy link
Owner

rafaqz commented Dec 20, 2022

Wow yes seems that has been happening since v0.4.0. Could this be a Tagbot problem? Or is it a github thing? I honestly have no idea how that actually works and calculates the changes. Maybe we should make sure the tagbot script is correct.

But, if the releases were accurate you could see what is breaking its:

#352

which changes getproperty on RasterStack so its like a NamedTuple and retrieves its Raster layers by name. Before it was just getfield. Nothing else breaks.

Edit: it seems I can tediously delete all the GeoData.jl releases one by one, maybe I can use the cli?

Edit2: I think it was just the old releases messing with tagbot. It should start working again now.

@rafaqz
Copy link
Owner

rafaqz commented Dec 20, 2022

@rafaqz rafaqz closed this as completed Dec 20, 2022
@rafaqz
Copy link
Owner

rafaqz commented Dec 20, 2022

Maybe we should always put BREAKING in the PR title so its easier to see which one is responsible

@mauro3
Copy link
Collaborator Author

mauro3 commented Dec 20, 2022

Excellent, thanks to much!

@rafaqz
Copy link
Owner

rafaqz commented Dec 20, 2022

Thanks for pointing it out those were very confusing release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants