Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leftover show statement in latest version when using Raster #340

Closed
tomchor opened this issue Nov 29, 2022 · 3 comments
Closed

Leftover show statement in latest version when using Raster #340

tomchor opened this issue Nov 29, 2022 · 3 comments

Comments

@tomchor
Copy link

tomchor commented Nov 29, 2022

I noticed that there's a instance of @show when I use Raster that was probably leftover from some debugging:

julia> Raster("xyz.PPN-NDTEST2.nc")
typeof(index) = Vector{Float64}
typeof(index) = Vector{Float64}
typeof(index) = Vector{Float64}
typeof(index) = Vector{Float64}
15×15×13×3 Raster{Float64,4} dbdz with dimensions: 
  Dim{:xC} Sampled Float64[-1395.704239009855, -1196.3179191513043, , 1196.3179191513043, 1395.704239009855] ForwardOrdered Regular Points,
  Dim{:yC} Sampled Float64[-1246.164499115942, -1046.7781792573912, , 1345.8576590452174, 1545.243978903768] ForwardOrdered Regular Points,
  Dim{:zF} Sampled Float64[-0.0, 46.11164504961419, , 575.9196534021572, 747.0] ForwardOrdered Irregular Points,
  Ti Sampled Float64[0.0, 124500.0, 249000.0] ForwardOrdered Regular Points
with missingval: missing
[:, :, 1, 1]
            -1246.16  -1046.78  -847.392  -648.006  -448.619  -249.233  -49.8466  149.54  348.926  548.312  747.699  947.085  1146.47  1345.86  1545.24
 -1395.7        0.0       0.0      0.0       0.0       0.0       0.0      0.0       0.0     0.0      0.0      0.0      0.0       0.0      0.0      0.0
 -1196.32       0.0       0.0      0.0       0.0       0.0       0.0      0.0       0.0     0.0      0.0      0.0      0.0       0.0      0.0      0.0
  -996.932      0.0       0.0      0.0       0.0       0.0       0.0      0.0       0.0     0.0      0.0      0.0      0.0       0.0      0.0      0.0
  -797.545      0.0       0.0      0.0       0.0       0.0       0.0      0.0       0.0     0.0      0.0      0.0      0.0       0.0      0.0      0.0
  -598.159      0.0       0.0      0.0       0.0       0.0       0.0      0.0       0.0     0.0      0.0      0.0      0.0       0.0      0.0      0.0
  -398.773      0.0       0.0      0.0       0.0       0.0       0.0      0.0       0.0     0.0      0.0      0.0      0.0       0.0      0.0      0.0
  -199.386      0.0       0.0      0.0       0.0       0.0       0.0      0.0       0.0     0.0      0.0      0.0      0.0       0.0      0.0      0.0
     0.0        0.0       0.0      0.0       0.0       0.0       0.0      0.0       0.0     0.0      0.0      0.0      0.0       0.0      0.0      0.0
   199.386      0.0       0.0      0.0       0.0       0.0       0.0      0.0       0.0     0.0      0.0      0.0      0.0       0.0      0.0      0.0
   398.773      0.0       0.0      0.0       0.0       0.0       0.0      0.0       0.0     0.0      0.0      0.0      0.0       0.0      0.0      0.0
   598.159      0.0       0.0      0.0       0.0       0.0       0.0      0.0       0.0     0.0      0.0      0.0      0.0       0.0      0.0      0.0
   797.545      0.0       0.0      0.0       0.0       0.0       0.0      0.0       0.0     0.0      0.0      0.0      0.0       0.0      0.0      0.0
   996.932      0.0       0.0      0.0       0.0       0.0       0.0      0.0       0.0     0.0      0.0      0.0      0.0       0.0      0.0      0.0
  1196.32       0.0       0.0      0.0       0.0       0.0       0.0      0.0       0.0     0.0      0.0      0.0      0.0       0.0      0.0      0.0
  1395.7        0.0       0.0      0.0       0.0       0.0       0.0      0.0       0.0     0.0      0.0      0.0      0.0       0.0      0.0      0.0
[and 38 more slices...]

Not a huge deal but I thought I'd create an issue about it. I'll try to find it and open a PR to remove it if indeed it's unintended.

@tomchor
Copy link
Author

tomchor commented Nov 29, 2022

Okay I just cloned the repo to look for it, but it seems that this was already removed in main! Is it okay to ask for a patch release in order to register this change?

@rafaqz
Copy link
Owner

rafaqz commented Dec 2, 2022

This should be resolve in the latest releases

@rafaqz rafaqz closed this as completed Dec 2, 2022
@tomchor
Copy link
Author

tomchor commented Dec 2, 2022

I just noticed you tagged a new release. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants