Fix line burning and test rasterize against GDAL
#330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #330 +/- ##
==========================================
- Coverage 78.82% 78.16% -0.66%
==========================================
Files 38 38
Lines 2970 3037 +67
==========================================
+ Hits 2341 2374 +33
- Misses 629 663 +34
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes line burning and adds some tests against gdal with
:center(no line burning) and:touches(line burning).Closes #326
@ayushpatnaikgit this should also improve the comparisons in #312 . If included an explicit test against ArchGDAL in the tests.
for a small shape,
rasterizewithboundary=:centeris identical to GDAL. The may be some differences for larger shapes.boundary=:toucheshas some disagreements with GDAL on pixel corners in the middle of lines but is pretty close after fixing this bug.