undefined references

[maxfreu]

The vscode linter tells me that there are some undefined references in /src, a hopefully complete list:

Rasters.jl/src/lookup.jl

Line 196 in 89b4aab

rebuild(lookup; data=i, order=o, span=sp)

Rasters.jl/src/openstack.jl

Line 26 in 89b4aab

Base.values(os::OpenStack{<:Any}) = (fs[k] for k in keys(fs))

Rasters.jl/src/polygon_ops.jl

Line 135 in 89b4aab

Iyperm[i] = li

Rasters.jl/src/polygon_ops.jl

Line 373 in 89b4aab

merge(acc, (; key=extrema(columns)))

Rasters.jl/src/polygon_ops.jl

Lines 408 to 411 in 89b4aab

	if ext isa Nothing
	return true
	else
	return Extents.intersects(geomextent, rasterext)

Rasters.jl/src/methods/extract.jl

Line 91 in 89b4aab

layer_vals = map(_ -> missing, layer_keys)

Rasters.jl/src/methods/rasterize.jl

Line 252 in 89b4aab

rasterize!(x, geom; fill=_featurefillval(feature, fill), kw...)

Maybe you want to take a second look.

[rafaqz]

Thanks, yeah I need to use some linting.Also be nice to have 100% test coverage one day...

[rafaqz]

Ok these seem to be in a few categories: obscure edge cases I never tested like reversing affine transformed dims, 3d polygons which are rare but really need testing, and actually bad bugs like rasterize for features.

If you are ever interested in helping improve test coverage it would be good to do some kind of drive push this up into the high 90s at some stage.

I also wonder if its possible to run this JET.jl in the tests so this cant happen again.

[maxfreu]

I just ran the entire package through JET, which creates a wall of text. I'm quite impressed, it not only found the bugs listed above, but also bugs in HDF5 and DiskArrays. Some of them could have been prevented by using a linter, but not all; it also traced generated code, which a linter is probably not able to do. The errors are mostly: undefined variables, "may throw xy" errors (mostly through undefined keywords / used kwargs without default), invalid builtin function calls, no method matching, trying to iterate over nothing, and some more. Maybe it's possible to filter / focus on one error type after the other, e.g. addressing undefined references first. The code I ran is super simple:

# in Rasters environment
]add Jet
using JET
report_package()

Including JET into the tests should also be possible, but requires some more effort.

[rafaqz]

I've been running that too! Got quite excited by how reliable everything will be once we have it set up. But it would be good to be able to turn off "may throw" reports and other junk, because we know, those errors are intentionally there...

I also found I needed to activate the package as an environment for the dependencies to work properly. Oh you said that

There is also this: https://github.com/julia-vscode/StaticLint.jl

Which is I guess what you are getting in VSCode. But I havent tried it standalone.