fix ncd write memory allocations, and error messages #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaqz
force-pushed
the
fix_ncd_write
branch
from
e54fde1
to
2880271
Compare
Codecov Report
@@ Coverage Diff @@
## main #320 +/- ##
==========================================
- Coverage 78.74% 78.73% -0.01%
==========================================
Files 38 38
Lines 2950 2949 -1
==========================================
- Hits 2323 2322 -1
Misses 627 627
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #317
@ayushpatnaikgit try this branch and see if it fixes your problem, It reduces allocations in the
writetests quite a lot.