Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for netcdf, missingval=nothing when there is not Missing in the type #308

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

rafaqz
Copy link
Owner

@rafaqz rafaqz commented Sep 8, 2022

closes #307

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #308 (2c22cab) into main (852e2ff) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
+ Coverage   80.23%   80.36%   +0.12%     
==========================================
  Files          38       38              
  Lines        2889     2913      +24     
==========================================
+ Hits         2318     2341      +23     
- Misses        571      572       +1     
Impacted Files Coverage Δ
src/sources/ncdatasets.jl 87.55% <100.00%> (+0.36%) ⬆️
src/series.jl 86.56% <0.00%> (+0.85%) ⬆️
src/filearray.jl 73.17% <0.00%> (+2.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rafaqz rafaqz merged commit 14dcf50 into main Sep 8, 2022
@rafaqz rafaqz deleted the fix_ncd_missingval branch September 8, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The eltype of a raster with missingval = missing is not Union{Missing, ...}
2 participants