Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affine maps for geotransforms #277

Merged
merged 8 commits into from
Jun 30, 2022
Merged

Affine maps for geotransforms #277

merged 8 commits into from
Jun 30, 2022

Conversation

rafaqz
Copy link
Owner

@rafaqz rafaqz commented Jun 30, 2022

Fixes the long standing error that rotated arrays don't load by adding an AffineProjected lookup.

DimensionalData and base methods mostly work as for other raster, like read/write, plotting and At or Near selectors.

But Between or .. interval selectors still give an error, because we need to work out what to actually do in this case. Possible filling the corners left by rotation with missing values is the best solution - but a lot more involved than regular selectors - especially for view.

Closes #263

@codecov-commenter
Copy link

Codecov Report

Merging #277 (fb46c8f) into main (d8783e9) will decrease coverage by 0.39%.
The diff coverage is 69.60%.

@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
- Coverage   81.30%   80.91%   -0.40%     
==========================================
  Files          37       37              
  Lines        2718     2788      +70     
==========================================
+ Hits         2210     2256      +46     
- Misses        508      532      +24     
Impacted Files Coverage Δ
src/methods/warp.jl 89.65% <ø> (+3.44%) ⬆️
src/show.jl 80.39% <0.00%> (-14.96%) ⬇️
src/lookup.jl 66.93% <42.30%> (-6.54%) ⬇️
src/methods/aggregate.jl 94.02% <50.00%> (ø)
src/methods/resample.jl 73.07% <71.42%> (-1.93%) ⬇️
src/sources/gdal.jl 92.60% <84.41%> (+0.79%) ⬆️
src/plotrecipes.jl 88.12% <100.00%> (+0.38%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@rafaqz rafaqz merged commit c44841b into main Jun 30, 2022
@rafaqz rafaqz deleted the affine branch June 30, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rotated/transformed dimensions
2 participants