add lazy flag to make laziness optional
#261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
glad to see this feature implemented. |
|
I urgently need this feature in one of my recent research. Hope this feature could be in the master branch soon. |
|
Yeah, there are some problems with CI in RasterDataSources.jl that keep making things fail. Im trying to fix, hopefully tonight. |
|
Awesome. Thank for your help. |
|
@kongdd see how this goes in CI. I'm pretty busy currently so it might not be tonight unfortunately. You can also just check out this branch manually if you need it. Like |
|
Got it. Thank u. I will have a try. |
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
==========================================
- Coverage 85.34% 85.27% -0.08%
==========================================
Files 36 37 +1
Lines 2593 2628 +35
==========================================
+ Hits 2213 2241 +28
- Misses 380 387 +7
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
lazyflag toRasterandRasterStackso that lazy loading is optional. For now it istrueby default, but this may change, or we can add package preference to set it manually.Closes #260