better filestack performance #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
==========================================
- Coverage 81.49% 81.34% -0.16%
==========================================
Files 61 61
Lines 4270 4337 +67
==========================================
+ Hits 3480 3528 +48
- Misses 790 809 +19 ☔ View full report in Codecov by Sentry. |
|
Thanks for improving this! But you shouldn't work so long on Sundays ;-) |
|
Not to worry, github tells me I have enjoyed eleven entire, healthy, commit-free Sundays in just the last year alone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overhauls both stack load and compile time. It uses type-unstable vectors for as long as possible at load to avoid compiling lots of functions on huge tuples.
The 130 layer stack in the tests now takes ~6 seconds to load the first time, and 0.5 seconds after that.
getindexafter usingopenis now essentially the same as using NCDatasets or GRIBDatasets directly.We should encourage using
open(st) do stblocks as much as possible forlazy=truestacks, its much faster now.Closes #226
(Sorry this took 2 years @maxfreu 😅 )