Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default value inside struct dyn #16741

Merged
merged 4 commits into from May 3, 2020
Merged

Change default value inside struct dyn #16741

merged 4 commits into from May 3, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 28, 2020

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the documentation and the radare2 book with the relevant information (if needed)

Detailed description
The error value (not found) inside RBinElfDynamicInfo was 0. The problem is that some value inside the dynamic section are 0 and it is VALID. So i change the default value.

PS: All size have a value of 0, imho an invalid size is 0 not a big value.

Test plan

...

Closing issues
#12732

@ghost
Copy link
Author

ghost commented Apr 30, 2020

@ret2libc Any opinion on this?

@ret2libc ret2libc marked this pull request as ready for review April 30, 2020 14:39
Copy link
Contributor

@ret2libc ret2libc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link
Author

ghost commented Apr 30, 2020

@ret2libc the appveyor has ended but you can't see it if you don't click on the link

@ret2libc
Copy link
Contributor

@ret2libc the appveyor has ended but you can't see it if you don't click on the link

I see... probably some issues with Github. Let's wait and see if it pass in a short time, otherwise @XVilka or @radare can merge it anyway.

@radare
Copy link
Collaborator

radare commented May 3, 2020

stil WIP? lgtm

@ghost ghost changed the title WIP - Change default value inside struct dyn Change default value inside struct dyn May 3, 2020
@ghost
Copy link
Author

ghost commented May 3, 2020

Nope @radare i forget to remove the flag

@ret2libc
Copy link
Contributor

ret2libc commented May 3, 2020

I restarted appveyor build which was stuck.

@radare radare merged commit 311ad81 into radareorg:master May 3, 2020
Emi1305 pushed a commit to Emi1305/radare2 that referenced this pull request Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants