-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FreeBSD buildfixes #10440
Comments
Can we have the freebsd maintainer to send a pullreq for this? Killing install-doc is a bad idea And the sdhostcc problem should be affecting other platforms if changed. So better have a pr |
Alternatively, you can advocate meson and ask them to switch from configure to meson.
|
That will never gonna happen. |
Here are some findings regarding MESON and freebsd:
It may worth investigating the possibilities of using MESON in freebsd, testing it and discussing it. |
I guess I am starting to script my own |
Met this problem during setting up the autobuilds for FreeBSD here: https://builds.sr.ht/~xvilka/radare2
|
Oh nice! Great finding @XVilka |
TODO: also run regression tests with these |
release is tonight, i though 1 year and a half was enough time to fix this |
can't compile. see: https://twitter.com/malwaremustd1e/status/1174702479432474625 |
log:
Reason: |
@unixfreaxjp what you mention on Twitter is a different thing, what compiler and FreeBSD version are you using if you do not mind ? I ll try to have a look later unless someone else find it. |
@devnexen yes, I also just realized that now too, along with announcing below the investigation result of the bug: I checked all source code:git-5bb241711983c5d8b548c7980058f1dda67fb5d6 3.9.0 --> sys.c: In function 'r_sys_run_rop': sys.c:1042: error: expected string literal before ')' token The investigation result:
The problem source:Ragg rop chain #13609 #13609 The solution proposed:I think we need to add _FREEBSD check to exclude it from R_SYS_ASM_START_ROP code below: :
#ifdef __x86_64__
# ifdef _MSC_VER
# define R_SYS_ASM_START_ROP() \
eprintf ("r_sys_run_rop: Unsupported arch\n");
# else
: Issue is opened with suggested workaround |
Checked. My box & legacies doesn't support
@radare @XVilka @devnexen @scrapbird @unixfreaxjp |
I may have a "slightly" better idea, I m building under FreeBSD 9.2 and realised it does not support this form of inline assembly. If I modify slightly it does compile. |
Ok so I ll try 9.3 i386 (did tested only amd64) just saw the details of your ticket. |
for freebsd 9.3 and 10.4 is needed for many software dev have both arch each, others are 11 and 12 on each arch, the rest are the "others" bsd's. |
still not closeable? |
@unixfreaxjp you may open issues in the r2dec and r2ghidra repos with a build error message. the plan is to switch to the new testsuite after 4.2, and then we will be able to enable the BSD testsuite and eventually automatically build r2dec and r2ghidra too |
i think we can close this now that we are building r2 in freebsd in CI |
I can not upgrade BSD servers to fir to my criteria of tests due to COVID19 emergency situation. Sorry for delay. Basically as workaround I slowly test all one by one booting systems locally under VM and it is super slow. I will post issue if significant bug is spotted. So far none of those level. |
Taken from https://svnweb.freebsd.org/ports/head/devel/radare2/Makefile?revision=463925&view=markup
Without it it tries to use GCC.
The text was updated successfully, but these errors were encountered: