-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull request for easier build and support maple mini #60
Comments
Hi, please send me the link to your branch with these modification. Is it available on GitHub? Best, |
Hi, the branch can be found here : https://github.com/vortex314/bluepill-serial-monster Regards |
@vortex314 while the overall idea of adding maple support seems reasonable, I have a number of questions regarding the implementation:
In the device_config.c the comment /* pin is occupied by USB */ is wrong. PIN is occupied by the LED. Even if the PIN is occupied by the LED, we should think about remapping it (are there free PINs), not disabling. Also I don't see a single word about Maple in README. At this point your branch cannot be merged. Question: what exactly should be changed for maple support? Is it only about the LED pin? |
Hi Kyrill, thanks for the detailed review, I admire the project you dis so far, some answers : Overall I used the platformio setup as it is much more convenient to get all pre-requisites than the steps described in the README. Also from my own experience I know the USB renumeration on a bluepill is unpredicatble, I had better results with maple boards.
Same applies to usb_io.c, however I don't see any non-formatting related changes there at all; At this point your branch cannot be merged. Question: what exactly should be changed for maple support? Is it only about the LED pin?
Hope this helps, Lieven |
I tried not to configure the txa pin for UART2 , however it needs one as otherwise it crashes in
As the code & doc in my repo https://github.com/vortex314/maple-serial-monster is incomplete for all cases,forget about the pull request. |
Hi, I cloned the repo locally and did slight modifications on the device config to enable some more features :
However I have no experience in how to create a pull request or I don't have enough access to push a proposal branch.
How do I proceed to push this code ?
Regards
Lieven
The text was updated successfully, but these errors were encountered: