Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Probably erroneous usb_endpoint_address_cdc_0_interrupt usage #58

Closed
vnodeng opened this issue May 3, 2022 · 2 comments
Closed

Probably erroneous usb_endpoint_address_cdc_0_interrupt usage #58

vnodeng opened this issue May 3, 2022 · 2 comments

Comments

@vnodeng
Copy link
Contributor

vnodeng commented May 3, 2022

The usb_descriptors.c file at line 333 refers to the usb_endpoints parameters array via usb_endpoint_address_cdc_0_interrupt constant, which is a bit suspicious because this is done in the descriptor of third UART. This doesn't affect current functionality because parameters of control endpoints happens to match, but introduces minor inconsistency.
@r2axz
Copy link
Owner

r2axz commented May 3, 2022

Yes, you are right. I actually also noticed this and already fixed in #57.

@vnodeng
Copy link
Contributor Author

vnodeng commented May 3, 2022

Ok, missed it, because github search is a bit flawed regarding the pull request details.

@vnodeng vnodeng closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@r2axz @vnodeng