Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is the maximum Integral disabled? #19

Open
benreu opened this issue Apr 11, 2022 · 0 comments
Open

Why is the maximum Integral disabled? #19

benreu opened this issue Apr 11, 2022 · 0 comments

Comments

@benreu
Copy link

benreu commented Apr 11, 2022

The line

AutoPID/AutoPID.cpp

Line 61 in fea6b99

//_integral = constrain(_integral, _outputMin/_Ki, _outputMax/_Ki);
which contains the Integrator max is disabled. I'm curious why? Is there some inherent problem I'm not aware of? Furthermore, would you accept a PR for a function like setMaxIntegrator (100) ?
@benreu benreu changed the title Why is the Intergrator maximum disabled? Why is the Integrator maximum disabled? Apr 12, 2022
@benreu benreu changed the title Why is the Integrator maximum disabled? Why is the maximum Integral disabled? Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benreu