Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: moment/moment
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: develop
Choose a base ref
...
head repository: qzoke/moment
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: develop
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 33 files changed
  • 1 contributor

Commits on Jun 19, 2024

  1. [misc] refactor all object type checks in single file 

    All the files in src/lib/utils that handled type checking have been merged into one file :
src/lib/utils/check-object-type.js

This file now includes following functions :
isArray(),
isDate(),
isFunction(),
isNumber(),
isObject(),
isString(),
isUndefined()
    @qzoke
    qzoke committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    38d196b View commit details
    Browse the repository at this point in the history

  2. [misc] refactor defaults.js and others 

    removed src/lib/utils/defaults.js and included it as a firstNonNullArgument() function in src/lib/create/from-array.js  where it was needed.

refactored nested ternary operator in src/lib/moment/calender.js for more readability.

import isLeapyear from utils instead of units.
    @qzoke
    qzoke committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    2c4082e View commit details
    Browse the repository at this point in the history
Loading