Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell portability problems: dash not supported #40

Closed
threepistons opened this issue Dec 4, 2018 · 2 comments
Closed

shell portability problems: dash not supported #40

threepistons opened this issue Dec 4, 2018 · 2 comments

Comments

@threepistons
Copy link

threepistons commented Dec 4, 2018

I have version 0.2.3 and I'm using Ubuntu 18.04 with sh symlinked to dash. When I run git fire against a repo with a stash, the stash isn't branched and pushed.

~/git/test(master) » git fire
Switched to a new branch '[email protected]'
On branch [email protected]
nothing to commit, working tree clean
Host key fingerprint is SHA256:UFAjDQH4wwzmGkeNYpztD5NuaIBVkrdFIuoaEN4vCVQ
+---[ECDSA 256]---+
|o.*E+o**+        |
|+*X+o..o..       |
|=O.B.o.          |
|* +=O  .         |
|o=oo+o  S        |
|o+ o..           |
|o .              |
|                 |
|                 |
+----[SHA256]-----+
X11 forwarding request failed on channel 0
Total 0 (delta 0), reused 0 (delta 0)
To gitlab.example.com:sample/test.git
 * [new branch]      [email protected] -> [email protected]
Branch '[email protected]' set up to track remote branch '[email protected]' from 'origin'.
/usr/local/bin/git-fire: 51: /usr/local/bin/git-fire: [[: not found

I can silence the error and push the stash by editing /usr/local/lib/mode_modules/git-fire/git-fire to replace the first line (#!/usr/bin/env sh) with either #!/usr/bin/env bash or #!/usr/bin/env zsh. I suspect that dash's lack of support for [[ causes this and it will affect other users of Debian-like distros.

@glensc
Copy link
Contributor

glensc commented Dec 4, 2018

fixes provided several times, merge capable developer, like @qw3rtman not responding

@qw3rtman
Copy link
Owner

qw3rtman commented Dec 6, 2018

Merged #34, fixing this issue.

@qw3rtman qw3rtman closed this as completed Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants