Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make certain ds fields optional and test #9

Merged
merged 4 commits into from
Feb 24, 2021
Merged

feat: make certain ds fields optional and test #9

merged 4 commits into from
Feb 24, 2021

Conversation

asim-shrestha
Copy link
Contributor

closes #8

@asim-shrestha asim-shrestha changed the title feat: make certain ds fields optinal and test feat: make certain ds fields optional and test Feb 24, 2021
awtkns
awtkns approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@awtkns awtkns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also bump the version

tests/conftest.py Outdated Show resolved Hide resolved
tests/test_rtstruct_builder.py Outdated Show resolved Hide resolved
tests/test_ds_helper.py Outdated Show resolved Hide resolved
rt_utils/ds_helper.py Show resolved Hide resolved
@asim-shrestha asim-shrestha merged commit 8c18a38 into main Feb 24, 2021
@awtkns awtkns deleted the 8-optinal-fields branch February 24, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awtkns awtkns awtkns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Certain Dataset Fields Optional
2 participants
@asim-shrestha @awtkns