feat: throw exception if rtstruct references images outside of series data #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asim-shrestha
commented
Mar 1, 2021
| @@ -91,20 +99,20 @@ def test_loading_valid_rt_struct(series_path): | |||
| assert hasattr(rtstruct.ds, 'ROIContourSequence') | |||
| assert hasattr(rtstruct.ds, 'StructureSetROISequence') | |||
| assert hasattr(rtstruct.ds, 'RTROIObservationsSequence') | |||
| assert len(rtstruct.ds.ROIContourSequence) == 4 | |||
There was a problem hiding this comment.
Changed the test rt struct file to only have 1 ROI within it
asim-shrestha
commented
Mar 1, 2021
| Method to validate RTStruct only references dicom images found within the input series_data | ||
| """ | ||
| # Blame DICOM for this nesting | ||
| for refd_frame_of_ref in ds.ReferencedFrameOfReferenceSequence: |
There was a problem hiding this comment.
lmk if i can make this cleaner. Also lmk if you have better ideas for method names
|
@carluri now is your time to become a contributor (if you review an make a change) 😉 |
awtkns
reviewed
Mar 1, 2021
Comment on lines
+74
to
+77
| raise Exception( | ||
| f'Loaded RTStruct references image(s) that are not contained in input series data. ' + | ||
| f'Problematic image has SOP Instance Id: {contour_image.ReferencedSOPInstanceUID}' | ||
| ) |
There was a problem hiding this comment.
Do we want to maybe throw an RTStuctException?
awtkns
reviewed
Mar 2, 2021
Remove DICOM nesting comment Co-authored-by: Adam Watkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10