return StreamErrors for all kinds of stream cancelations #3681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is errors.Is'ed by libp2p and the fmt.Errorf messages didn't passed that test: https://github.com/libp2p/go-libp2p/blob/82315917f76ca1e9e1c3aca3ad957080f0ac870c/p2p/transport/quic/stream.go#L23
Codecov Report
@@ Coverage Diff @@
## master #3681 +/- ##
==========================================
+ Coverage 85.36% 86.93% +1.57%
==========================================
Files 140 142 +2
Lines 10246 12085 +1839
==========================================
+ Hits 8746 10505 +1759
- Misses 1111 1156 +45
- Partials 389 424 +35
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Jorropo
approved these changes
Jan 26, 2023
| s.cancelWriteErr = writeErr | ||
| s.cancelWriteErr = &StreamError{StreamID: s.streamID, ErrorCode: errorCode, Remote: remote} |
There was a problem hiding this comment.
That a nice change, this tripped me up when doing the first commit because receive_stream also did the error in cancelWriteImpl and not CancelWrite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently @Jorropo didn't allow me to push to his branch in #3674, so I'm recreating this PR.
@Jorropo Would you mind giving this PR a quick review?