Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server incorrectly allows 0-RTT with reduced limits when using tls.Config.GetConfigForClient #4548

Closed
marten-seemann opened this issue Jun 3, 2024 · 0 comments · Fixed by #4550
Labels
Milestone

Comments

@marten-seemann
Copy link
Member

diff --git a/integrationtests/self/zero_rtt_test.go b/integrationtests/self/zero_rtt_test.go
index 46b3786dc..c77281bf9 100644
--- a/integrationtests/self/zero_rtt_test.go
+++ b/integrationtests/self/zero_rtt_test.go
@@ -817,7 +817,9 @@ var _ = Describe("0-RTT", func() {
                connIDLen := l
 
                It(fmt.Sprintf("correctly deals with 0-RTT rejections, for %d byte connection IDs", connIDLen), func() {
-                       tlsConf := getTLSConfig()
+                       tlsConf := &tls.Config{
+                               GetConfigForClient: func(*tls.ClientHelloInfo) (*tls.Config, error) { return getTLSConfig(), nil },
+                       }
                        clientConf := getTLSClientConfig()
                        dialAndReceiveSessionTicket(tlsConf, nil, clientConf)
                        // now dial new connection with different transport parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant