-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http3: respect request context while reading from the response body #4205
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Go documentation for the request context says:
The
http.Response.Body
therefore needs to return the context error as well. I confirmed that this is what HTTP/2 does.Currently, we don't even pass the context to the body, and it's not clear to me how to correctly respect the context without spawning a new Go routine, since the
Stream.Read
call is blocking call.Originally posted by @marten-seemann in #4203 (comment)
The text was updated successfully, but these errors were encountered: