Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when qlogging a Version Negotiation packet #2639

Closed
marten-seemann opened this issue Jun 30, 2020 · 0 comments · Fixed by #2640
Closed

Crash when qlogging a Version Negotiation packet #2639

marten-seemann opened this issue Jun 30, 2020 · 0 comments · Fixed by #2640
Assignees
Labels

Comments

@marten-seemann
Copy link
Member

See ipfs/kubo#7512.

It looks like qlog.Tracer.ReceivedVersionNegotiationPacket() is called after qlog.Tracer.Export() has been called.
This could happen when the session runs into a handshake timeout, and then receives the Version Negotiation packet at just the right moment.

We should handle Version Negotiation packets in the session, so we don't have a race condition between Export() and other logging calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant