Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexer store: Loosen package unique constraints #166

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

crozzy
Copy link
Collaborator

@crozzy crozzy commented Jun 20, 2024

The action was reporting more packages that Clair proper due to the fact that the constraints on what makes a package unique in Clair were slightly more lax (this is done at the datastore level in Clair). This change brings the logic in line. https://github.com/quay/claircore/blob/main/datastore/postgres/migrations/indexer/01-init.sql#L107

@crozzy crozzy requested a review from a team as a code owner June 20, 2024 22:49
@crozzy crozzy requested review from hdonnay and removed request for a team June 20, 2024 22:49
Copy link
Member

@hdonnay hdonnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

The action was reporting more packages that Clair proper due to the fact
that the constraints on what makes a package unique in Clair were
slightly more lax (this is done at the datastore level in Clair). This
change brings the logic in line.

Signed-off-by: crozzy <[email protected]>
@crozzy
Copy link
Collaborator Author

crozzy commented Jun 24, 2024

/fast-forward

@github-actions github-actions bot merged commit 2ac03d4 into quay:main Jun 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants