Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make window a two-element vector #2105

Closed
2 of 3 tasks
kbenoit opened this issue Apr 13, 2021 · 2 comments
Closed
2 of 3 tasks

Make window a two-element vector #2105

kbenoit opened this issue Apr 13, 2021 · 2 comments

Comments

@kbenoit
Copy link
Collaborator

kbenoit commented Apr 13, 2021

As implemented in tokens_select(), we could add this to the window argument in:

  • kwic()
  • fcm() - since ordered = TRUE is already like window = c(0, 5). See workaround here.
  • tokens_compound() - in fact, this looks like it's already available in qatd_cpp_tokens_compound()
@koheiw
Copy link
Collaborator

koheiw commented Apr 3, 2023

I don't think we need window to be two-elements in kwic(), but you can do it easily.

@kbenoit
Copy link
Collaborator Author

kbenoit commented Apr 3, 2023

I agree we don't need it in kwic. Let's close this.

@kbenoit kbenoit closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants