Add Touchpad widget

[serweryn617]

A widget that shows touchpad state and allows to toggle it with mouse click or keybind.

What are your thoughts?

[elParaguayo]

Thanks for this. I don't have any particular objections to including in the main repo but have made some comments.

I would like to include a test for this widget, particularly to test the use of custom get/set_state_func functions.

[serweryn617]

I've added unit tests, updated everything and tested if it works. Everything looks good.

[elParaguayo]

You need to ignore the widget in this test:

qtile/test/widgets/test_widget_init_configure.py

Lines 60 to 62 in 2b5ad3c

	no_test = [widgets.Mirror, widgets.PulseVolume] # Mirror requires a reflection object
	no_test += [widgets.ImapWidget] # Requires a configured username

[serweryn617]

Looks like it's only a subprocess call that fails because it requires xinput.
I can also just add an override for the device_id parameter so this call is never executed.
I don't know what would be a better option.

+overrides = [
+    (widgets.Touchpad, {"device_id": "0"}),  # Touchpad requires device id or working xinput
+]

[elParaguayo]

If you can get it to work with the override, that's better.

[serweryn617]

Should be good now. Are there any other tests that run on all widgets? I only checked the ones I've added, not the entire suite

[elParaguayo]

One other thought, does this work in Wayland?

[serweryn617]

The default functions probably not. I don't really have a way to test it.

[elParaguayo]

Ok. Pinging @jwijenbergh to see if he knows if it can be done on Wayland.

If not, you can set supported_backends = {"x11"} as a class attribute of your widget.

[serweryn617]

I suppose I could use libinput on Wayland instead of xinput?

I'll test it tomorrow.

[serweryn617]

I've added X11 as the only supported backend.

If you are OK with it, I would like to close this PR. I can create a new one, with Wayland support later, but I need to prepare my environment first and look into how it all works on Wayland.

[serweryn617]

Is there anything else I should add/change @elParaguayo ?

[github-actions]

This PR is stale because it has been open 90 days with no activity. Remove the status: stale label or comment, or this will be closed in 30 days.