Battery widget, "wrong" value on low battery notification

[omulh]

Issue description

For the Battery widget, the value shown in the low level notification differs (by 1%) from the one shown in the widget itself.
This is not a bug per se, but something that is slightly annoying and should be fairly easy to solve.

After looking at the code, I think this is caused by the way the percentage is printed on the notification and on the widget. i.e. percent = int(status.percent * 100) is what goes to the notification, while something like '{percent:2.0%}'.format(percent=status.percent) is what goes to the widget.
One method always rounds down while the other rounds up and down.

I think this could be solved by changing one line in the poll function of the Battery class:

percent = int(status.percent * 100)
if percent < self.notify_below:
  if not self._has_notified:
    send_notification(
      "Warning",
      "Battery at {0}%".format(percent), <-- this line
      urgent=True,
      timeout=self.timeout,
    )

should change to:

"Battery at {0:2.0%}".format(status.percent),

Version

0.26.0

Backend

Wayland (experimental)

Config

Not relevant, imo

Logs

None

Required

• I have searched past issues to see if this bug has already been reported, and it hasn't been.
• I understand that people give their precious time for free, and thus I've done my very best to make this problem as easy as possible to investigate.

[tych0]

Can you send a patch?

[omulh]

I'm afraid I don't know how to do that. I haven't used github for this kind of things yet. If you point me in the right direction I can give it a try