Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: qmuntal/opc Loading
base: v0.7.11
Choose a base ref
...
head repository: qmuntal/opc Loading
compare: v0.7.12
Choose a head ref
  • 6 commits
  • 5 files changed
  • 3 contributors

Commits on Nov 30, 2023

  1. Fix escaping in part name normalization

    The iteration of reading the input string of the function was
    problematic. When finding a pre-encoded character, for instance
    %28 (which is an open bracket - '('), all three characters were
    written in the destination string, but the reading of the input
    string continued with the character after '%', which was '2'. The
    correct behavior is for the reading to continue with the character
    after '8'.
    
    The writing in the destination also had a bug. Instead of writing
    the 3 characters ('%', '2' and '8') one after another, the first
    two were written correctly, namely at position j and j+1 in the
    destination string, but the third character was written at j+3
    instead of at j+2.
    
    This problem had not appeared before in the tests in part_test,
    because there was no test case that has both a pre-encoded
    character and a character to be encoded. When there are no
    characters to be encoded in the input string, the string is
    returned as it was given in the input. Such a test case would have
    resulted in an index out of range error.
    cristiancreteanu committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    1178565 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Merge pull request #20 from cristiancreteanu/fix-name-normalization-e…

    …scaping
    
    Fix escaping in part name normalization
    qmuntal committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    376b40c View commit details
    Browse the repository at this point in the history
  2. fix TestPart_validate

    qmuntal committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    7244905 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #21 from qmuntal/fixtest

    Fix TestPart_validate
    qmuntal committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    db8b2d1 View commit details
    Browse the repository at this point in the history
  4. Update README.md

    qmuntal committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    c7234ba View commit details
    Browse the repository at this point in the history
  5. remove release.yml

    qmuntal committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    8cd781b View commit details
    Browse the repository at this point in the history
Loading