Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added YD60MQ ISO layout #8815

Merged
merged 3 commits into from
Apr 23, 2020
Merged

Added YD60MQ ISO layout #8815

merged 3 commits into from
Apr 23, 2020

Conversation

marchein
Copy link
Contributor

Description

I added support for ISO layout of the YD60MQ pcb.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Added support for ISO layout of the YD60MQ pub

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested review from noroadsleft and a team April 16, 2020 00:10
fauxpark
fauxpark requested changes Apr 16, 2020
View reviewed changes
keyboards/yd60mq/keymaps/iso/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team April 19, 2020 01:26
noroadsleft
noroadsleft approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@marchein
Copy link
Contributor Author

So is there anything left I should do so it can be merged?

@noroadsleft
Copy link
Member

Applying fauxpark's suggestion would probably prompt a second sign-off.

@marchein marchein requested a review from fauxpark April 21, 2020 11:08
@fauxpark
Copy link
Member

Thanks!

@fauxpark fauxpark merged commit 0722986 into qmk:master Apr 23, 2020
mrlinuxfish pushed a commit to mrlinuxfish/qmk_firmware that referenced this pull request May 3, 2020
@marchein @mrlinuxfish
Added YD60MQ ISO layout (qmk#8815)
0fc23cf
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@marchein @lorenzoernesto
Added YD60MQ ISO layout (qmk#8815)
c997a34
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@marchein @sowbug
Added YD60MQ ISO layout (qmk#8815)
e694e47
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@marchein @turky
Added YD60MQ ISO layout (qmk#8815)
aad8271
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@marchein @jakobaa
Added YD60MQ ISO layout (qmk#8815)
b7d42d8
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@marchein @sjmacneil
Added YD60MQ ISO layout (qmk#8815)
2599015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marchein @noroadsleft @fauxpark @drashna @zvecr