Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setPinInput doesn't ensure pin isn't set as inputHigh #6238

Closed
Duckle29 opened this issue Jul 2, 2019 · 0 comments
Closed

setPinInput doesn't ensure pin isn't set as inputHigh #6238

Duckle29 opened this issue Jul 2, 2019 · 0 comments
Labels
bug core discussion help wanted

Comments

@Duckle29
Copy link
Contributor

Duckle29 commented Jul 2, 2019

Describe the Bug

setPinInput() only sets the DDRx register to 0, it doesn't ensure that the pin state is set to 0 too. This means to return to a high-Z input, one has to use writePinLow()

https://github.com/Duckle29/qmk_firmware/blob/pincontrol/quantum/quantum.h#L155

#6237 aims to solve this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug core discussion help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@drashna @Duckle29 @tzarc