Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Various keyboards contain invalid led config #17105

Open
zvecr opened this issue May 15, 2022 · 0 comments
Open

[Bug] Various keyboards contain invalid led config #17105

zvecr opened this issue May 15, 2022 · 0 comments

Comments

@zvecr
Copy link
Member

zvecr commented May 15, 2022

Describe the Bug

With the recently introduced data driven led config, the crude validation has flagged the following keyboards;

⚠ boardsource/beiwagon: led_config: beiwagon.c: Unable to parse g_led_config position data
    22 leds
    18 flags
    12 led position
⚠ ryanskidmore/rskeys100: led_config: rskeys100.c: OOB within g_led_config matrix data
    103 leds
    OOB - led[117] used in config
⚠ melgeek/mj64/rev1: led_config: rev1.c: OOB within g_led_config matrix data

⚠ kbdfans/odin/rgb: led_config: rgb.c: Unable to parse g_led_config position data
    missing position data for 7 leds
⚠ keybee/keybee65: led_config: keybee65.c: Unable to parse g_led_config position data
    missing position data for 19 leds
⚠ mechlovin/hannah60rgb/rev2: led_config: rev2.c: Unable to parse g_led_config position data
    missing position data for 5/8 leds
⚠ handwired/hnah108: led_config: hnah108.c: Unable to parse g_led_config position data
    missing position data for 3/1 leds
⚠ linworks/fave84h: led_config: fave84h.c: Unable to parse g_led_config position data
    missing position data for underglow leds
⚠ linworks/fave87h: led_config: fave87h.c: Unable to parse g_led_config position data
    missing position data for underglow leds

Also, various keyboards contain content that makes it difficult to parse;

MATH
⚠ xelus/dawn60/rev1_qmk: led_config: rev1_qmk.c: Unable to parse g_led_config matrix data
⚠ xelus/pachi/rgb/rev1: led_config: rev1.c: Unable to parse g_led_config matrix data
⚠ xelus/pachi/rgb/rev2: led_config: rev2.c: Unable to parse g_led_config matrix data
⚠ handwired/dygma/raise/ansi: led_config: ansi.c: Unable to parse g_led_config matrix data
⚠ handwired/dygma/raise/iso: led_config: iso.c: Unable to parse g_led_config matrix data

MACROS
⚠ opendeck/32/rev1: led_config: rev1.c: Unable to parse g_led_config position data
    others
⚠ rgbkb/sol/rev2: led_config: rev2.c: Unable to parse g_led_config matrix data
    ifdefs
⚠ rgbkb/pan/rev1/32a: led_config: pan.c: Unable to parse g_led_config position data
    ifdefs
⚠ rgbkb/pan/rev1/proton_c: led_config: pan.c: Unable to parse g_led_config position data
    ifdefs

While warnings may be suppressed for some scenarios in the short term (e.g. use of macros), others (like referencing an led that does not exist) will become hard errors in a next develop cycle. Those keyboards not fixed, will most likely have RGB support removed, or potentially be removed from the repo altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant