Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes issue #1926 #1928

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fixes issue #1926 #1928

merged 1 commit into from
Jun 21, 2024

Conversation

vsemichev
Copy link
Contributor

Corrects missing secondary Y-axis title

Description

Corrects the line in the drawing.go file that set secondary axis title to nil.

Related Issue

#1926

Motivation and Context

I need this fix for one of my projects where I need to set the secondary Y-axis title

How Has This Been Tested

Ran go test which came out clean. Performed two tests using my project binary - one to create a combo column + line chart with a secondary Y-axis that has a title and another one that created a combo column + line chart with invisible secondary Y-axis. Both tests produced expected results.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 20, 2024
@xuri xuri linked an issue Jun 20, 2024 that may be closed by this pull request
@xuri xuri added this to Bugfix in v2.9.0 Jun 21, 2024
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit 4e6457a into qax-os:master Jun 21, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
v2.9.0
Bugfix
Development

Successfully merging this pull request may close these issues.

Secondary axis title is not displayed.
2 participants