Saving workbook with reverse sorted internal part path to keep same hash of identical files #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update zip sort order Original order ``` [Content_Types].xml _rels/.rels docProps/app.xml docProps/core.xml xl/_rels/workbook.xml.rels xl/sharedStrings.xml xl/styles.xml xl/theme/theme1.xml xl/workbook.xml xl/worksheets/sheet2.xml xl/worksheets/sheet3.xml xl/worksheets/sheet4.xml xl/worksheets/sheet5.xml xl/worksheets/sheet6.xml xl/worksheets/sheet7.xml xl/worksheets/sheet8.xml xl/worksheets/sheet9.xml ``` New order ``` xl/_rels/workbook.xml.rels xl/pivotCache/pivotCacheDefinition1.xml xl/pivotTables/_rels/pivotTable1.xml.rels xl/pivotTables/pivotTable1.xml xl/sharedStrings.xml xl/styles.xml xl/theme/theme1.xml xl/workbook.xml xl/worksheets/_rels/sheet8.xml.rels xl/worksheets/sheet1.xml xl/worksheets/sheet12.xml xl/worksheets/sheet2.xml xl/worksheets/sheet3.xml xl/worksheets/sheet4.xml xl/worksheets/sheet5.xml xl/worksheets/sheet6.xml xl/worksheets/sheet7.xml xl/worksheets/sheet8.xml [Content_Types].xml _rels/.rels docProps/app.xml docProps/core.xml ```
xuri
added
the
size/M
xuri
reviewed
Apr 30, 2024
Saving workbook with reverse sorted internal part path to keep same hash of identical files
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1890 +/- ##
=======================================
Coverage 99.21% 99.21%
=======================================
Files 32 32
Lines 24085 24085
=======================================
Hits 23895 23895
Misses 102 102
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xuri
approved these changes
Apr 30, 2024
xuri
added
size/XS
barlevd
added a commit
to barlevd/excelize
that referenced
this pull request
Apr 30, 2024
This closes qax-os#1889, refs qax-os#1732 and qax-os#1735 (qax-os#1890)
xuri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update zip sort order
Original order
New order
PR Details
Description
This change sorts the inter zip streams so that the Excel file passes validation as a Microsoft Excel 2007+
Related Issue
Motivation and Context
How Has This Been Tested
This change was tested and verified that the resulting output includes the Microsoft Excel 2007+ metadata to show up properly using
filetool, andmmmagic.Run on Mac OS.
Upload of the file to a server now shows it is a proper xlsx file.
This change doesn't affect other areas of the code.
Types of changes
Checklist