Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azimuthal Integral Tutorial - Case 2 not working #58

Open
andy-bridger opened this issue Mar 3, 2021 · 5 comments
Open

Azimuthal Integral Tutorial - Case 2 not working #58

andy-bridger opened this issue Mar 3, 2021 · 5 comments

Comments

@andy-bridger
Copy link

npt_rad no longer keyword
other issues associated with dp.get_azimuthal_integral1d(npt_rad =100, detector_dist=camera_length, detector=detector)

@pc494
Copy link
Member

pc494 commented Mar 3, 2021

It looks like npt_rad has been replaced by npt in the function signature, which should resolve the first problem.

@andy-bridger
Copy link
Author

Yeh, tracked that down, the rest of the issues seemed to be with the specifying a detector and detector distance within this method. I think there has been a change in the code and now there is a set_ai method, I'm not certain exactly how it has changed but it no longer functions as shown in the demo

@pc494
Copy link
Member

pc494 commented Mar 4, 2021

Okay, sounds like I will need to rewrite it then, I hadn't noticed the scale of those changes; thanks for the bug report.

@pc494
Copy link
Member

pc494 commented Mar 14, 2021

@CSSFrancis I had a look at this today (both demo 07 and 09) - is there any chance these are easy fixes for you?

@CSSFrancis
Copy link
Member

Yes. I can make the changes to the demo (hopefully today but definitely tomorrow). I think that this demo never got updated with the latest changes (my fault).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants