Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make better use of crystallographic libraries #18

Open
dnjohnstone opened this issue Jul 16, 2019 · 1 comment
Open

Make better use of crystallographic libraries #18

dnjohnstone opened this issue Jul 16, 2019 · 1 comment
Labels
enhancement New feature, request, or improvement

Comments

@dnjohnstone
Copy link
Member

We depend on diffpy.structure for atomic structure manipulations but perhaps currently under-utilise some of the functionality of that package.

One example is that the is_lattice_hexagonal() function in sim_utils is probably superseded by the isSpaceGroupLatPar() function in SymmetryUtilities in diffpy.

Another case is when we need dot products, angles etc - we should be using Lattice.angle, Lattice.norm etc from diffpy.structure.

This mostly requires us getting a bit more familiar with diffpy.structure and should have the advantage of making things more robust and more general moving forwards.

This may involve implementing a space group analyzer e.g. https://github.com/materialsproject/pymatgen/blob/master/pymatgen/symmetry/analyzer.py for diffpy structures.

That functionality depends mostly on spglib https://atztogo.github.io/spglib/python-spglib.html#python-spglib

Note we should also consider use and dependence on other crystallographic libraries

@dnjohnstone dnjohnstone added the enhancement New feature, request, or improvement label Jul 29, 2019
@dnjohnstone dnjohnstone added this to the v0.3.0 milestone Jul 29, 2019
@dnjohnstone
Copy link
Member Author

This is a useful reference for this: https://journals.iucr.org/j/issues/2019/04/00/gj5229/index.html

@dnjohnstone dnjohnstone modified the milestones: v0.3.0, future Mar 23, 2020
@hakonanes hakonanes removed this from the future milestone Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, request, or improvement
Projects
None yet
Development

No branches or pull requests

2 participants