Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Test TensorDict representation #380

Closed
12 tasks
vmoens opened this issue Aug 28, 2022 · 0 comments
Closed
12 tasks

[Feature Request] Test TensorDict representation #380

vmoens opened this issue Aug 28, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@vmoens
Copy link
Contributor

vmoens commented Aug 28, 2022

Motivation

Some misrepresentations of tensordict have been reported (e.g. #367)
We should test the following types:

  • plain TensorDict with regular tensors
  • nested tensordicts
  • stacked tensordict (nested)
  • indexed tensordicts (nested):
    • with integers
    • with slice
    • with None
    • with tensors
    • with masks
    • indexed with integer from stacked
  • when moved from device to device
  • when modifying the batch_size

The test should write explicitely what the repr string is and match it against the __repr__ output.
When writing the test, one should make sure that the print output matches the tensordict content.

@vmoens vmoens added the enhancement New feature or request label Aug 28, 2022
@vmoens vmoens self-assigned this Aug 28, 2022
@vmoens vmoens closed this as completed Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant